Skip to content

[7.x] Provide psr/container-implementation#33020

Merged
taylorotwell merged 2 commits intolaravel:7.xfrom
AegirLeet:provide-psr-container
May 30, 2020
Merged

[7.x] Provide psr/container-implementation#33020
taylorotwell merged 2 commits intolaravel:7.xfrom
AegirLeet:provide-psr-container

Conversation

@AegirLeet
Copy link
Copy Markdown
Contributor

See laravel/ideas#2241.

As recommended in PSR-11, this declares that illuminate/container provides the psr/container-implementation virtual package.

@GrahamCampbell GrahamCampbell marked this pull request as draft May 30, 2020 08:12
@GrahamCampbell
Copy link
Copy Markdown
Collaborator

This must be added to the root composer.json file too.

@GrahamCampbell GrahamCampbell changed the title Provide psr/container-implementation in illuminate/container [7.x] Provide psr/container-implementation in illuminate/container May 30, 2020
@GrahamCampbell GrahamCampbell changed the title [7.x] Provide psr/container-implementation in illuminate/container [7.x] Provide psr/container-implementation May 30, 2020
@GrahamCampbell GrahamCampbell marked this pull request as ready for review May 30, 2020 08:15
@AegirLeet
Copy link
Copy Markdown
Contributor Author

Doesn't it propagate because laravel/framework replaces illuminate/container? symfony/symfony doesn't provide it, but it's listed here, so I assumed that's how it works.

@taylorotwell taylorotwell merged commit c29c15b into laravel:7.x May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants