Repository navigation
[6.x] Fix Model::withoutEvents() not registering listeners inside boot() - #33149
Merged
taylorotwell merged 1 commit intoJun 8, 2020
Merged
Conversation
If an Eloquent model class is instantiated for the first time inside a withoutEvents() Closure, any model boot() callbacks registering custom event listeners will be skipped. Instead of removing the dispatcher, replaced it with a null pattern implementation. Registration method calls still go through to the concrete dispatcher however fired event dispatch() calls become noop.
derekmd
force-pushed
the
without-events-registers-listeners
branch
from
June 8, 2020 14:59
f6ebf5f to
18b68cf
Compare
Contributor
Author
|
Packagist and/or GitHub hosting seem to be eating it at the moment so CI step "Install dependencies" for Composer is failing from network timeouts. |
Member
|
Thanks |
salmanarshad321
pushed a commit
to salmanarshad321/framework
that referenced
this pull request
Sep 23, 2026
If an Eloquent model class is instantiated for the first time inside a withoutEvents() Closure, any model boot() callbacks registering custom event listeners will be skipped. Instead of removing the dispatcher, replaced it with a null pattern implementation. Registration method calls still go through to the concrete dispatcher however fired event dispatch() calls become noop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32935
Eloquent model
boot()hooks (andbooting()/booted()in 7.x+) run once per-class in each request. If an Eloquent model class is instantiated for the first time insideModel::withoutEvents(),boot()callbacks registering custom event listeners expected later will be skipped. e.g.,Instead of
Model::withoutEvents()removing the event dispatcher from all models, replace it with a null pattern implementation. Fired eventdispatch()attempts are noop when insidewithoutEvents(). However event listeners can still be registered on the concrete dispatcher for post-withoutEvents()calls.