Skip to content

[6.x] Prevent to serialize uninitialized properties#33644

Merged
taylorotwell merged 2 commits into
laravel:6.xfrom
dkulyk:patch-4
Jul 24, 2020
Merged

[6.x] Prevent to serialize uninitialized properties#33644
taylorotwell merged 2 commits into
laravel:6.xfrom
dkulyk:patch-4

Conversation

@dkulyk

@dkulyk dkulyk commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Fixes #33637

No need to serialize uninitialized properties.

@GrahamCampbell

Copy link
Copy Markdown
Collaborator

Could you add a test which covers this please?

@GrahamCampbell GrahamCampbell self-requested a review July 24, 2020 17:34
Comment thread src/Illuminate/Queue/SerializesModels.php
@dkulyk dkulyk requested a review from GrahamCampbell July 24, 2020 17:46
@taylorotwell

Copy link
Copy Markdown
Member

This method only exists on PHP >= 7.4?

@dkulyk

dkulyk commented Jul 24, 2020

Copy link
Copy Markdown
Contributor Author

This method used by PHP >= 7.4 only.
PHP < 7.4 is using __sleep/__wakeup

@taylorotwell taylorotwell merged commit 36fdbd4 into laravel:6.x Jul 24, 2020
@dkulyk dkulyk deleted the patch-4 branch July 27, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants