Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Prevent to serialize uninitialized properties #33644

Merged
merged 2 commits into from
Jul 24, 2020
Merged

[6.x] Prevent to serialize uninitialized properties #33644

merged 2 commits into from
Jul 24, 2020

Conversation

dkulyk
Copy link
Contributor

@dkulyk dkulyk commented Jul 24, 2020

Fixes #33637

No need to serialize uninitialized properties.

@GrahamCampbell
Copy link
Member

Could you add a test which covers this please?

@GrahamCampbell GrahamCampbell self-requested a review July 24, 2020 17:34
@taylorotwell
Copy link
Member

This method only exists on PHP >= 7.4?

@dkulyk
Copy link
Contributor Author

dkulyk commented Jul 24, 2020 •
edited
Loading

This method used by PHP >= 7.4 only.
PHP < 7.4 is using __sleep/__wakeup

@taylorotwell taylorotwell merged commit 36fdbd4 into laravel:6.x Jul 24, 2020
@dkulyk dkulyk deleted the patch-4 branch July 27, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkulyk @GrahamCampbell @taylorotwell