Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix validation rule 'required_unless' when other field value is boolean. #33715

Merged
merged 1 commit into from
Jul 31, 2020
Merged

[6.x] Fix validation rule 'required_unless' when other field value is boolean. #33715

merged 1 commit into from
Jul 31, 2020

Conversation

liquid207
Copy link
Contributor 

Validator::make(['a' => false ], [ 'b' => 'required_unless:a,false']);

This validator should pass, but fail, this PR fix it.

@driesvints driesvints changed the title Fix validation rule 'required_unless' when other field value is boolean. [6.x] Fix validation rule 'required_unless' when other field value is boolean. Jul 31, 2020
driesvints
driesvints approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since required_if works in the same way this lgtm.

@liquid207
Copy link
Contributor Author

@driesvints Thanks

@taylorotwell taylorotwell merged commit 6a15aa5 into laravel:6.x Jul 31, 2020
@liquid207 liquid207 deleted the fix-validation-rule-required-unless branch August 2, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liquid207 @driesvints @taylorotwell