Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Allow nested errors in json assertion #33989

Merged
merged 1 commit into from Aug 24, 2020
Merged

[7.x] Allow nested errors in json assertion #33989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Testing/TestResponse.php
View file
Open in desktop
Expand Up @@ -729,7 +729,7 @@ public function assertJsonValidationErrors($errors, $responseKey = 'errors')

PHPUnit::assertNotEmpty($errors, 'No validation errors were provided.');

$jsonErrors = $this->json()[$responseKey] ?? [];
$jsonErrors = Arr::get($this->json(), $responseKey) ?? [];

$errorMessage = $jsonErrors
? 'Response has the following JSON validation errors:'.
Expand Down
14 changes: 14 additions & 0 deletions tests/Testing/TestResponseTest.php
View file
Open in desktop
Expand Up @@ -611,6 +611,20 @@ public function testAssertJsonValidationErrorsCustomErrorsName()
$testResponse->assertJsonValidationErrors('foo', 'data');
}

public function testAssertJsonValidationErrorsCustomNestedErrorsName()
{
$data = [
'status' => 'ok',
'data' => ['errors' => ['foo' => 'oops']],
];

$testResponse = TestResponse::fromBaseResponse(
(new Response)->setContent(json_encode($data))
);

$testResponse->assertJsonValidationErrors('foo', 'data.errors');
}

public function testAssertJsonValidationErrorsCanFail()
{
$this->expectException(AssertionFailedError::class);
Expand Down