[6.x] Fix for empty fallback_locale

[ahmedsayedabdelsalam]

// ar
'foo' => ''
// en
'foo', => 'bar'

before
trans('file.foo',[],'ar') // ''

after
trans('file.foo',[],'ar') // 'bar'

#34128

[ahmedsayedabdelsalam]

I tried to update laravel version but I think this fix is not released yet.

[driesvints]

@ahmedsayedabdelsalam releases are done on Tuesdays.

[ahmedsayedabdelsalam]

Great! Thanks.

[driesvints]

We've reverted this as this was a breaking change.

[ahmedsayedabdelsalam]

Is there any plan to fix that or this is not an issue?

[driesvints]

This was the expected behavior and it's unlikely that we'll ever change this.

[ahmedsayedabdelsalam]

Hmmm. Most of Excel Sheet Translation packages pull the not translated languages as an empty string value and I think it's logic because the data type for translations is designed to be strings

For me I'll fix it in my project but I suggest making a config key determines when the translator should fallback if an empty strings or null.

Like: 'fallback_when_empty' => true, // translations.php config file

Anyway thanks for your time.