Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Added tg:// protocol in "url" validation rule #34464

Merged
merged 1 commit into from
Sep 22, 2020
Merged

[8.x] Added tg:// protocol in "url" validation rule #34464

merged 1 commit into from
Sep 22, 2020

Conversation

AtCliffUnderline
Copy link

Right now urls for Telegram Desktop application are not passing URL validation rule. So, this PR just adding tg:// protocol to this validation rule.

@driesvints driesvints changed the title Added tg:// protocol in "url" validation rule [8.x] Added tg:// protocol in "url" validation rule Sep 22, 2020
@taylorotwell taylorotwell merged commit 379a8ed into laravel:8.x Sep 22, 2020
@zlodes
Copy link
Contributor

zlodes commented Oct 1, 2020

@taylorotwell
Hi! What you think about this soooo long regex? Maybe we need to refactor it?..
I think there is could be array with protocols to improve readability.

@Mdhesari
Copy link

Mdhesari commented Oct 1, 2020

@zlodes
He is right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants