New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Add dontRelease option to RateLimited and RateLimitedWithRedis job middleware #35010

Merged

taylorotwell merged 1 commit into laravel:8.x from paras-malhotra:dont_release_option

Oct 28, 2020

Contributor

paras-malhotra commented Oct 28, 2020 •

edited

Loading

Similar to the WithoutOverlapping middleware, this PR adds the dontRelease option to RateLimited job middleware like so:

public function middleware()
{
    return [(new RateLimited('backups'))->dontRelease()];
}

If the dontRelease method is called, the job is not released back to the queue when the limit is exceeded.


          [8.x] Add dontRelease option to RateLimited and RateLimitedWithRedis …

00d4739

…job middleware

paras-malhotra mentioned this pull request

[8.x] Bring Rate Limiters to Jobs #34829

Merged

taylorotwell merged commit 00d4739 into laravel:8.x

paras-malhotra deleted the dont_release_option branch

October 28, 2020 21:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment