Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Allow overriding the MySQL server version for database queue driver #35263

Merged
merged 1 commit into from Nov 18, 2020

Conversation

cfroystad
Copy link
Contributor

@cfroystad cfroystad commented Nov 18, 2020

Azure managed MySQL comes with the problem that PDO::ATTR_SERVER_VERSION will always return 5.6.42 even if the actual version is 8.0.x.

This is a known limitation since 2017 and it appears Microsoft has no intention of fixing the problem.

Therefore the fixes to deadlocks in the queues is not applied.

This PR incorporates the principle from PR 32708 in the database queue driver to support manually overrinding the database version.

As a side note, Drupal seems to be moving towards using SELECT version() instead of PDO::ATTR_SERVER_VERSION, but that's out of scope for this PR.

@taylorotwell taylorotwell merged commit a7e7852 into laravel:8.x Nov 18, 2020
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants