[9.x] More flexibility when time traveling in tests #35338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally targeted 8.x #35326 , was informed it was a breaking change, so switched to 9.x
The purpose of this PR is to bring parity to the
InteractsWithTime::travelTo
parameter type hint so it matches theCarbon::setTestNow
type hint.IMO this will allow for more flexibility when time traveling in tests. Here are some examples that would be supported if this PR were merged.
Currently, these all result in a type error.
Meanwhile, these all work fine.
Unless I'm missing something, the
DateTimeInterface
requirement seems like an arbitrary restriction when Carbon's implementation ofsetTestNow
has no such restriction.