[6.x] Avoid using niden/actions-memcached #35499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
commented
Dec 5, 2020
| @@ -1,7 +1,7 @@ | |||
| version: '3' | |||
| services: | |||
| memcached: | |||
| image: memcached:1.5-alpine | |||
| image: memcached:1.6-alpine | |||
There was a problem hiding this comment.
NB This is used when someone runs bin/tests.sh locally.
|
@GrahamCampbell think you sent this to the wrong branch? |
|
Memcached tests are still being skipped on 8.x, do you have any idea how we can make them run? |
I don't think they are. They are only being skipped on PHP 8.0, and that's just because setup-php is silently skipping installing that extension because no PHP 8.0 compatible release has been made yet. |
|
@GrahamCampbell yeah I meant PHP 8, sorry. |
|
Will be fixed only one the next release of memcached is pushed to pecl. php-memcached-dev/php-memcached#466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it doesn't let us control the version (so stuff might start randomly breaking), and we don't need some special action for memcached anyway... we can load the docker image just like we do for mysql and redis. In fact, that is exactly what the old memcached action was doing anyway... but jut not letting us set the major.minor version.