Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Support retrieving URL for Sftp adapter #36120

Merged
merged 3 commits into from
Feb 2, 2021
Merged

[8.x] Support retrieving URL for Sftp adapter #36120

merged 3 commits into from
Feb 2, 2021

Conversation

sharifzadesina
Copy link
Contributor

Small change to support retrieving URLs for Sftp adapter just like Ftp adapter.

Example:

Storage::disk('sftp')->url('file.jpg');

driesvints
driesvints approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this looks okay to me.

@GrahamCampbell GrahamCampbell changed the title [8.x.x] Support retrieving URL for Sftp adapter [8.x] Support retrieving URL for Sftp adapter Feb 2, 2021
@taylorotwell taylorotwell merged commit 46e3bfb into laravel:8.x Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sharifzadesina @driesvints @taylorotwell