[8.x] Improve the exception thrown when JSON encoding response contents fails #36851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves on the opaque exception of "The Response content must be a string or object implementing __toString(), “boolean” given." that occurs whenever a call to $response->setContent($varThatFailsJsonEncoding) is made. It is difficult to debug the original exception, because to the developer they are not providing a boolean anywhere in their code, they are passing an array or an object to setContent() and expecting it to work; not knowing that Laravel internally tries to json_encode() that value before passing it along to Symfony, which only understands string values as response contents. Refs: - https://stackoverflow.com/a/38772790/6652884 - https://octobercms.com/forum/post/error-on-reset-password - https://octobercms.com/plugin/support/pixel-shop/bug-and-italian-translation - https://laravelquestions.com/2017/08/16/the-response-content-must-be-a-string-or-object-implementing-__tostring-boolean-given/ - rainlab/user-plugin#294
|
@driesvints if you guys would be willing to backport this to 6.x too, that would be fantastic :) |
|
On Laravel 8 why don't we use https://stitcher.io/blog/new-in-php-73#json-errors-can-be-thrown-rfc |
driesvints
changed the title
|
@LukeTowers nice, thanks for this. I'm not sure about 6.x, I'll let @taylorotwell decide on that. I also agree that if we introduce exception throwing, the new |
|
Yeah, I thought about doing that, but there were too many places where I'd have to add that to trickle up to here and then those places suddenly throwing exceptions could be unexpected behaviour. Plus it's only in 7.3 so it wouldn't work for 6.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves on the opaque exception of "The Response content must be a string or object implementing __toString(), “boolean” given." that occurs whenever a call to $response->setContent($varThatFailsJsonEncoding) is made. It is difficult to debug the original exception, because to the developer they are not providing a boolean anywhere in their code, they are passing an array or an object to setContent() and expecting it to work; not knowing that Laravel internally tries to json_encode() that value before passing it along to Symfony, which only understands string values as response contents.
Refs: