Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Adds Model key extraction to id on whereKey() and whereKeyNot() #37184

Merged
merged 1 commit into from
Apr 30, 2021
Merged

[8.x] Adds Model key extraction to id on whereKey() and whereKeyNot() #37184

merged 1 commit into from
Apr 30, 2021

Conversation

DarkGhostHunter
Copy link
Contributor

This PR allows to get the key of a Model when a Model instance is issued on whereKey() and whereKeyNot() methods to the Builder for relationships.

Problem & Solution

If a developer issues a Model instance to whereKey() or whereKeyNot(), these methods will make a WHERE IN clause with all the model attributes, mainly because a Model implements Arrayable.

To avoid this, these methods will check first if the $id is a Model instance, and get the key from it.

$passenger->tickets()->whereHas('airline', fn (Builder $query) => $query->whereKey($airline))->get();

@netpok
Copy link
Contributor

netpok commented Apr 30, 2021

I like this feature, but in my opinion it should support multiple keys too.

$forExample->whereKey([$model1, $model2])->get();

@taylorotwell taylorotwell merged commit 7920ca5 into laravel:8.x Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants