[9.x] Move to anonymous migrations #37598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
time to drop "down" methods too? 😏 |
|
@browner12 I wish 😄 |
|
What happen if I do: php artisan queue:failed-table
# wait few seconds
php artisan queue:failed-tablePreviously we'll get duplicated class |
|
@crynobone That's indeed a side effect of anonymous migrations. We could check for the filename part after the timestamp but then it could collide with other similar named migrations. I don't think there's any way around this. But this should really be caught early on in development as the duplicate migration will throw an explicit failure when it's run. |
chu121su12
added a commit
to chu121su12/framework
that referenced
this pull request
Jun 5, 2021
This reverts commit 95b1899.
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes class names for migration stubs since now with anonymous migrations these aren't needed anymore.
#37352 also already removed them from existing stubs for the
MigrationCreatorso I also made changes to remove the resolving of the class name when populating the stub in that class.