[8.x] Make sure availableIn returns positive values

[rickycheers]

Problem

When running a job on Laravel Vapor if a rate limiter middleware is added to that job, like below

public function middleware()
{
    RateLimiter::for('name', function ($job) {
        return Limit::perMinute(400);
    });

    return [new RateLimited('name')];
}

The following error message from SQS pops up in the logs intermittently.

<?xml version="1.0"?><ErrorResponse xmlns="http://queue.amazonaws.com/doc/2012-11-05/"><Error><Type>Sender</Type><Code>I (truncated...)
 InvalidParameterValue (client): Value -1624201534 for parameter DelaySeconds is invalid. Reason: DelaySeconds must be >= 0 and <= 900. - <?xml version="1.0"?><ErrorResponse xmlns="http://queue.amazonaws.com/doc/2012-11-05/"><Error><Type>Sender</Type><Code>InvalidParameterValue</Code><Message>Value -1624201534 for parameter DelaySeconds is invalid. Reason: DelaySeconds must be &gt;= 0 and &lt;= 900.</Message><Detail/></Error><RequestId>...</RequestId></ErrorResponse>

I tracked down the problem to Illuminte\Cache\RateLimiter::availableIn where it can some times return negative values apparently when a "timer" value is not yet set in the cache. (I guess this only happens under heavy loads)

I was able to spot one in the wild when that happens. Here's an example:

---

Solution

Make sure availableIn always return a positive value. This way Illuminate\Queue\Middleware\RateLimited::getTimeUntilNextRetry can return an appropriate value.

Perhaps Illuminate\Queue\Middleware\RateLimitedWithRedis::getTimeUntilNextRetry requires a similar prevention? Let me know if you think it does and I can work on it as well.