Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add Filesystem::replaceInFile method #38069

Merged
merged 3 commits into from
Jul 20, 2021
Merged

[8.x] Add Filesystem::replaceInFile method #38069

merged 3 commits into from
Jul 20, 2021

Conversation

ryangjchandler
Copy link
Contributor

This pull request introduces a new Filesystem::replaceInFile($search, $replace, $path) method. This method can be found in both Breeze and Jetstream and I've needed the same method too so it made sense to try and PR into the framework.

@taylorotwell
Copy link
Member

May want to update the doc block with the actual types str_replace accepts. You can pass more than just string. It accepts arrays as well.

@ryangjchandler
Copy link
Contributor Author

Yes, of course. Will sort that out shortly.

@ryangjchandler
Copy link
Contributor Author

@taylorotwell All done!

@taylorotwell taylorotwell merged commit aca553a into laravel:8.x Jul 20, 2021
@ryangjchandler ryangjchandler deleted the feature/replace-in-file branch July 20, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants