[8.x] Support a proxy URL for mix hot #38118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect new ENV variable; Useful if you're serving a local app with ngrok, to change the url that gets output if in hot mode.
Style violation; remove spaces.
stevesweets
changed the title
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect new ENV variable; Useful if you're serving a local app with ngrok, to change the url that gets output if in hot mode.
My use case: shopify app being built, react front end. Making live tweaks to the app and want to see them reflected inside the shopify interface. Running on ngrok to make local dev possible. Was manually changing app url's back and forth, but this makes things a lot easier.