Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add cache_locks table to stub #38152

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

jellisii
Copy link
Contributor

Modified migration stub to create required cache_locks table when using the artisan command cache:table

@GrahamCampbell
Copy link
Member

This would not be used out of the box, so why include this?

@jellisii
Copy link
Contributor Author

This would not be used out of the box, so why include this?

This is something I tripped on when setting up the cache for my project and attempting to set up a scheduled task that uses onOneServer(). There's no reference to the atomic locks documentation from there, and the table is required to make that option behave and not throw an error.

This could possibly be just a documentation update that needs to happen as well, but my thinking was making the database cache driver behave identically to the other drivers that also support atomic locks out of the box.

@taylorotwell taylorotwell merged commit eaacad4 into laravel:8.x Jul 28, 2021
@GrahamCampbell GrahamCampbell changed the title [8.x] Add cache_locks table to stub. [8.x] Add cache_locks table to stub Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants