[8.x] Add --implicit (and -i) option to make:rule #38480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
taylorotwell
added a commit
to laravel/docs
that referenced
this pull request
Aug 31, 2021
* Document make:rule new --implicit option Added in [laravel/framework#38480](laravel/framework#38480) * Update validation.md Co-authored-by: Taylor Otwell <taylor@laravel.com>
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
* Add $baseRule to stub
* {{ ruleType }} instead of {{ $baseRule }}
* Use --implicit option to switch to ImplicitRule
* Add getOptions method
* Add missing import
* Deference to our StyleCI overlord
* Update RuleMakeCommand.php
Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward PR, does what's written on the tin. In line with the papercuts PRs going on these days.
I might be blind, but I don't find tests for the make:* commands. This addition is really simple anyway.
If I'm wrong, just point me to the file, and I'll oblige.
Cheers