Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Improves Support\Collection and Database\Eloquent\Collection type definitions #38538

Merged
merged 23 commits into from Aug 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3ad9429
Adds CI workflow
nunomaduro Aug 11, 2021
b13559b
Adds phpstan
nunomaduro Aug 11, 2021
4a17695
Adds work in progress regarding generic collections
nunomaduro Aug 11, 2021
0d92200
Fixes missing template
nunomaduro Aug 11, 2021
c47728b
Renames template
nunomaduro Aug 11, 2021
d56156c
Updates test
nunomaduro Aug 11, 2021
ab0058a
Apply fixes from StyleCI
taylorotwell Aug 11, 2021
97b71ac
Adds work in progress regarding generic collections
nunomaduro Aug 12, 2021
09b77c3
Adds work in progress regarding generic collections
nunomaduro Aug 13, 2021
acf574e
Adds work in progress regarding generic collections
nunomaduro Aug 13, 2021
338110d
Adds work in progress regarding generic collections
nunomaduro Aug 21, 2021
36ab22b
Adds work in progress regarding generic collections
nunomaduro Aug 23, 2021
a35ddcb
Styling
nunomaduro Aug 23, 2021
e249f05
Apply fixes from StyleCI
taylorotwell Aug 23, 2021
b93207f
Apply fixes from StyleCI
taylorotwell Aug 23, 2021
f409bbb
Adds work in progress regarding generic collections
nunomaduro Aug 24, 2021
d6c4291
Remove work on Models
nunomaduro Aug 25, 2021
dfcadb6
Revert "Remove work on Models"
nunomaduro Aug 25, 2021
449a374
Removes `prefer-lowest`
nunomaduro Aug 25, 2021
4aa15ab
Removes non needed code on CI job
nunomaduro Aug 25, 2021
8c14725
Fixes `Eloquent\Collection::load` types
nunomaduro Aug 25, 2021
f7430a9
Adds work in progress regarding generic collections
nunomaduro Aug 25, 2021
1c4f459
Fixes `Eloquent\Collection::load` related methods
nunomaduro Aug 26, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflows/types.yml
@@ -0,0 +1,43 @@
name: types

on:
push:
pull_request:
schedule:
- cron: '0 0 * * *'

jobs:
linux_tests:
runs-on: ubuntu-20.04

strategy:
fail-fast: true
matrix:
php: ['8.0']
include:
- php: '8.1'
flags: "--ignore-platform-req=php"

name: PHP ${{ matrix.php }}

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
tools: composer:v2
coverage: none

- name: Install dependencies
uses: nick-invision/retry@v1
with:
timeout_minutes: 5
max_attempts: 5
command: composer update --prefer-stable --prefer-dist --no-interaction --no-progress ${{ matrix.flags }}

- name: Execute type checking
continue-on-error: ${{ matrix.php > 8 }}
run: vendor/bin/phpstan
1 change: 1 addition & 0 deletions composer.json
Expand Up @@ -88,6 +88,7 @@
"mockery/mockery": "^1.4.3",
"orchestra/testbench-core": "^7.0",
"pda/pheanstalk": "^4.0",
"phpstan/phpstan": "^0.12.94",
"phpunit/phpunit": "^9.4",
"predis/predis": "^1.1.2",
"symfony/cache": "^5.3"
Expand Down
4 changes: 4 additions & 0 deletions phpstan.neon.dist
@@ -0,0 +1,4 @@
parameters:
paths:
- types
level: max