Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] ofMany to decide relationship name when it is null #38889

Merged
merged 1 commit into from
Sep 21, 2021
Merged

[8.x] ofMany to decide relationship name when it is null #38889

merged 1 commit into from
Sep 21, 2021

Conversation

SagarNaliyapara
Copy link
Contributor

@SagarNaliyapara SagarNaliyapara commented Sep 21, 2021

I was able to replicate similar issue as #37402 when using using latestOfMany or oldestOfMany (working fine with ofMany)

So this pr appends "_of_many" to the one of many join alias when the relation name is the same as the table name. (similar to #37411)

@taylorotwell taylorotwell merged commit f267d7c into laravel:8.x Sep 21, 2021
victorvilella pushed a commit to cdsistemas/framework that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants