[8.x] Add --pretend option for model:prune command #38945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks; sending in a PR for the docs soon. |
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
* Add --pretend option for model:prune command * Fix tests * Fix code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--pretendoption tomodel:prune, similar to the one formigrate. As prune is a potentially destructive command (a typo in a query could wipe out the wrong half of your database!), it's helpful to have an extra way to "sanity check" before committing.The
pretendoption will print the number of records matching theprunable()query. (I considered printing out the query instead, asmigrate's does, but that might be less useful, since it won't take chunking into account and might produce an expensive query.)If this PR is accepted, I'll go ahead to update the docs.