-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Revert "[9.x] Update psr/log version" and fix properly #38952
Conversation
What does removing the |
Lots of libs still only support v1 and breaking v1 support is silly. When we can easily support everything, we should. |
Fair enough, even though I'm more on the "let's push the community forward" line of thinking (by making Laravel 9 support psr log v2 and v3 instead of all three major versions). For v1 there's still Laravel <=8. |
I don't agree that's a good approach here. We can certainly recommend people v3, but until everyone gets caught up, we just needlessly stopping people from upgrading. Maybe once v3 is up to 30% of the downloads, we could reconsider, maybe for Laravel 10. |
For me scarifying the type strictness to allow backward compatibility with v1 and v2 is fine, but I proposed this change because I got interface incompatibility PHP errors when using PHP 8.1 and psr/log 3, I will check if it's now working but if you just revert the previous change we likely have the incompatibility again. |
This is not a straight up revert. It fixes compatibility with v3, without breaking v1 and v2. |
Yeh. :) |
Reverts #38852. Supports psr log v1, v2 and v3.