[8.x] Fix haveibeenpwnd failures #39038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
* Store artifacts * DD * Apply fixes from StyleCI * disable test * Bump timeout * Fix mocks * Bump timeout again * wip * wip * wip Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
PHLAK
pushed a commit
to PHLAK/framework
that referenced
this pull request
Oct 20, 2021
* Store artifacts * DD * Apply fixes from StyleCI * disable test * Bump timeout * Fix mocks * Bump timeout again * wip * wip * wip Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the default timeout for haveibeenpwnd API calls which caused our builds to randomly fail because of timeouts.
I've also included one fix to unbind the exception handler after a DNS test. It previously caused the handler to stay bound to the container and give false and unclear exceptions later on for subsequent failing tests.