[8.x] Update SchemaState Process to remove timeout #39139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As shown in Symphony Process docs: https://symfony.com/doc/current/components/process.html#process-timeout All Process spawned have a default timeout of 60 seconds. For a pg_dump script. 60 seconds might or might not be enough especially if this is run in a CI/CD envrionment where process contention (in shared or virtual hardware) is an issue. Removing the timeout is great because running migrations could be seen as a long lived process by most users and developers.
GrahamCampbell
changed the title
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
As shown in Symphony Process docs: https://symfony.com/doc/current/components/process.html#process-timeout All Process spawned have a default timeout of 60 seconds. For a pg_dump script. 60 seconds might or might not be enough especially if this is run in a CI/CD envrionment where process contention (in shared or virtual hardware) is an issue. Removing the timeout is great because running migrations could be seen as a long lived process by most users and developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
"Dumper" (pg_dump/ pg_restore) migrations can timeout on slow machines, or when dumps are fairly decent in size.
Proposed Solution
Remove the timeout for long lived processes such as pg_restore.
Default timeout is 60s, Symphony Process docs: https://symfony.com/doc/current/components/process.html#process-timeout
I didn't include any tests as it doesn't seem like this would need it. I encounter the 60second timeout on a GitLab instance that runs tests. During times when the shared server is being utilized a lot, the duration of the pg_restore process can last longer than 60s. I hope the team considers including this suggestion.