Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Allow users to specify options for migrate:fresh for DatabaseMigration trait #39637

Conversation

monaye
Copy link
Contributor

@monaye monaye commented Nov 16, 2021

Currently, the DatabaseMigration trait doesn't allow users to specify options for migrate:fresh, but, RefreshDatabase does allow.
To make consistent for both traits, this PR

  1. moved migrateFreshUsing related methods to a trait
  2. added migrateFreshUsing options to DatabaseMigration trait
  3. added test for HasMigrateFreshUsing, DatabaseMigration, and RefreshDatabase

I wasn't sure if using trait from trait would violate the Laravel coding standard. Please feel free to suggest a preferred way of organizing.

Monaye Win added 2 commits November 16, 2021 09:39
- added migrateFreshUsing options to DatabaseMigration trait
- added test for HasMigrateFreshUsing, DatabaseMigration and RefreshDatabase
@monaye monaye force-pushed the features/add_migrate_fresh_using_options_to_databasemigration branch from 40e59ed to e2aa770 Compare November 16, 2021 18:11
@monaye monaye force-pushed the features/add_migrate_fresh_using_options_to_databasemigration branch from e2aa770 to 672f9a2 Compare November 16, 2021 18:12
@GrahamCampbell GrahamCampbell changed the title Allow users to specify options for migrate:fresh for DatabaseMigration trait [8.x] Allow users to specify options for migrate:fresh for DatabaseMigration trait Nov 16, 2021
@taylorotwell taylorotwell merged commit 19343fd into laravel:8.x Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants