[9.x] Skip unnecessary check before calling openssl_encrypt
#40108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP
7.4
(before7.4.13
)openssl_encrypt
emitted a warning when the$tag
parameter was passed and the chosen cipher was not an AEAD cipher (AEAD ciphers set$tag
by reference, other ciphers do not use this at all).Since
7.4.13
and8.0.0
this has been resolved and$tag
is simply ignored, even if passed. This PR simplifies the code by removing the now unnecessary (but previously necessary) check.Here's the PHP fix
php/php-src@6c6a58e
And the PHP documentation for
openssl_encrypt
https://www.php.net/manual/en/function.openssl-encrypt.php