Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Use str_contains instead of strpos #40207

Merged
merged 2 commits into from
Dec 30, 2021
Merged

[9.x] Use str_contains instead of strpos #40207

merged 2 commits into from
Dec 30, 2021

Conversation

selcukcukur
Copy link
Contributor

No description provided.

@dinhquochan
Copy link
Contributor

👎 this PR because Laravel 8.x required 7.3 that version does not have str_contains() function.

@selcukcukur
Copy link
Contributor Author

👎 this PR because Laravel 8.x required 7.3 that version does not have str_contains() function.

It can be used with the symfony/polyfill-php80 package. The str_contains method on php 7.x.

@selcukcukur selcukcukur changed the title [9.x & 8.x] Used str_contains instead of strpos. [9.x] Used str_contains instead of strpos. Dec 30, 2021
@GrahamCampbell
Copy link
Member

This PR is not for Laravel 8. It's for Laravel 9, which is PHP 8.0.2+ only.

@dammy001
Copy link
Contributor

Exactly @GrahamCampbell

@taylorotwell taylorotwell merged commit 2beec5d into laravel:master Dec 30, 2021
@GrahamCampbell GrahamCampbell changed the title [9.x] Used str_contains instead of strpos. [9.x] Use str_contains instead of strpos Dec 30, 2021
@otilor otilor mentioned this pull request Jan 1, 2022
Closed
@lucasmichot lucasmichot mentioned this pull request Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@selcukcukur @dinhquochan @GrahamCampbell @dammy001 @taylorotwell