Fix sometimes validation for nested arrays

[jarektkaczyk]

Fixes not working 'sometimes' optional check for nested arrays.

[taylorotwell]

Need more examples of what this fixes. Paste something that was broken before and is now fixed. Also there are spacing problems in this pull.

[jarektkaczyk]

The issue came up here: http://stackoverflow.com/questions/22892058/laravel-sometimes-validator-fails-with-nested-arrays

Imagine form with array data:
Form:

Then:
$rules = ['user.phone' => 'required'];
$data = ['user' => ['phone' => null]];

Validator::make($data, $rules)->passes(); // false

BUT
$rules = ['user.phone' => 'sometimes|required'];
$data = ['user' => ['phone' => null]];

Validator::make($data, $rules)->passes(); // true

Validator checking optional rule can't get to the nested array and find proper key, thus returns always true. Check the tests, you'll find example there.

About spacing - there were indents with spaces, but in latest push there are tabs.

[jarektkaczyk]

Although previous solution worked, it was overkill. In fact one tiny fix in Validator - using array_dot, solves the issue.

[GrahamCampbell]

Indentation is still wrong here.

[GrahamCampbell]

Also, please squash this when you are done. 7 commits or more will be a bit much. :)

[jarektkaczyk]

Squashed, indentations corrected. Check it now please.

[GrahamCampbell]

👍 from me.

[ghost]

this definitely should be included in public release

[ghost]

Also is worth noting that documentation is wrong about sometimes implementation.

$v = Validator::make($data, array(
    'email' => 'sometimes|required|email',
));

Clearly here sometimes is pointless used in conjunction with required as the latter seems to have precedence.
Example should be:

$v = Validator::make($data, array(
    'email' => 'sometimes|email',
));