[9.x] Update Mailable.php

[rentalhost]

Allow ->from(new Address($address, $name)) support again (was ->from($address, $name) in Laravel 8).

[rentalhost]

Just to be clear, with the Laravel 9, the call to ->from() and similar methods stopped supporting email address and name and started to support only the address itself (without the name). However, it still allows receiving an Address object from Symfony Mailer, which contains both information. However, the normalization process throws an exception when using Address, even though the method says accept.

In this case, I still suggest an update to the guide:

Instead of using ->from($address, $name) use ->from(new Address($address, $name)).

[taylorotwell]

Are we unable to support ->from($address, $name) in Laravel 9? Why do we need to force people to create an Address instance?

[rentalhost]

@taylorotwell I do not see any problem to keep support to old way (that I personally prefer).

But the current code is:

    public function from(Address|string ...$addresses): static
    {
        return $this->setListAddressHeaderBody('From', $addresses);
    }

To support old way it need be modified.

The PR is only a fix to supports also Address, as this method parameter indicates.

[rentalhost]

Ah! It seems these methods are provided directly by Symfony Mailer. Anyway, the Laravel Message will create an Address instance and the exception will be throw anyway:

framework/src/Illuminate/Mail/Message.php

Lines 42 to 56 in fbe7ed8

	/**
	* Add a "from" address to the message.
	*
	* @param string|array $address
	* @param string|null $name
	* @return $this
	*/
	public function from($address, $name = null)
	{
	is_array($address)
	? $this->message->from(...$address)
	: $this->message->from(new Address($address, (string) $name));
	return $this;
	}

[taylorotwell]

Hmm, so does ->from($address, $name) work? I got a little lost in the last message. What do we need to fix?

[rentalhost]

Not in fact, because it will throw an exception when you set the $name. As the normalizeRecipient() will not handle the instanceof Address, it will just return the own instance of Address that does not supports $email property (or $name). Then the PR fixes that.

[taylorotwell]

Thanks