Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix loadAggregate not correctly applying casts #41025

Closed
wants to merge 1 commit into from
Closed

[8.x] Fix loadAggregate not correctly applying casts #41025

wants to merge 1 commit into from

Conversation

aalyusuf
Copy link
Contributor

Currently "loadExists" only applies the "bool cast" on the first model in a collection and skips the rest.

@driesvints
Copy link
Member

If you can, a test that proves the bug fix could be helpful here.

@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants