Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with option overriding introduced in #40954. The problem is that by default a value of
'options' => null
gets added when the default value of a HTTP call (get
,post
,...) is left empty. Becausearray_merge_recursive
was changed toarray_replace_recursive
, the default value removed the value ofquery
set withwithOptions
.The way I fixed it is to filter out any
null
value of options before sending the request. It doesn't seems you want to addnull
values to a request? However, if users are explicitly removing options set withwithOptions
by assigningnull
values, this will no longer work. But all tests pass right now and the docs don't note anything about that behavior so I don't think that's expected.Related: #40954 & 30e341b
Fixes #41382