Skip to content

[9.x] Redesign php artisan schedule:list Command.#41445

Merged
taylorotwell merged 17 commits into
laravel:9.xfrom
xiCO2k:feat/redesign-schedule-list
Mar 12, 2022
Merged

[9.x] Redesign php artisan schedule:list Command.#41445
taylorotwell merged 17 commits into
laravel:9.xfrom
xiCO2k:feat/redesign-schedule-list

Conversation

@xiCO2k

@xiCO2k xiCO2k commented Mar 11, 2022

Copy link
Copy Markdown
Member

This PR Improves the look for the php artisan schedule:list command.

The design was heavily inspired by the new version of the route:list.

Before:

image

After

image

Also there is available a verbose mode that will show the full cli path, *raw dates and description.

Verbose Mode

image

Cheers,
Francisco

@xiCO2k

xiCO2k commented Mar 11, 2022

Copy link
Copy Markdown
Member Author

Looks like the $this->artisan(ScheduleListCommand::class, ['-v' => true]) is interfering with RouteListCommandTest. maybe it need to be set as default to OutputInterface::VERBOSITY_NORMAL.

Thoughts?

@taylorotwell

Copy link
Copy Markdown
Member

@xiCO2k ready now?

@xiCO2k

xiCO2k commented Mar 12, 2022

Copy link
Copy Markdown
Member Author

Yep

@taylorotwell taylorotwell merged commit d13c348 into laravel:9.x Mar 12, 2022
@taylorotwell

Copy link
Copy Markdown
Member

Thanks for your work on this! ❤️

@xiCO2k xiCO2k deleted the feat/redesign-schedule-list branch March 12, 2022 01:28
@flightsupport

Copy link
Copy Markdown

I think scheduled jobs should be visible without having to set the -v flag.
With many scheduled jobs, the output is not meaningful.

Output without -v
*/5 * * * * ................................................................. Next Due: 3 minutes from now

Output with -v

*/5 * * * *  .................................................. Next Due: 2022-03-15 20:35:00 +00:00
               ⇁ App\Jobs\ShiftSupervisor

@driesvints

Copy link
Copy Markdown
Member

@flightsupport please see #41494

@xiCO2k

xiCO2k commented Mar 15, 2022

Copy link
Copy Markdown
Member Author

It is not that much clear a Job, but I will think on a way to show the job correctly like a command schedule. Thanks for pointing that out @flightsupport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants