[9.x] Handle Symfony defaultName deprecation#41555
Merged
taylorotwell merged 4 commits into9.xfrom Mar 18, 2022
Merged
Conversation
Jubeki
reviewed
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds handling for Symfony's deprecated
$defaultNameproperty on console commands in the upcoming Symfony 6.1 release. To mitigate deprecation notices we'll need to implement the newAsCommandattribute that ships with Symfony v6.See the related Symfony PR: symfony/symfony#45361
And issue: symfony/symfony#43600
Merging this into master will fix our failing tests there. After this is merged on master, I'll take the additional step to remove all
$defaultNameproperties.We'll also need to do this for all first party libraries that make use of the
$defaultNameproperty. Additionally, all apps and packages that make use of the$defaultNameproperty will need to migrate to this new syntax.