[9.x] Adds isEqual to compare file hashes in filesystem - #41586
Merged
Conversation
isEqual to compare file hashes in filesystem.isEqual to compare file hashes in filesystem
crynobone
added a commit
to crynobone/framework
that referenced
this pull request
Mar 22, 2022
driesvints
pushed a commit
that referenced
this pull request
Mar 22, 2022
taylorotwell
pushed a commit
to illuminate/support
that referenced
this pull request
Mar 22, 2022
Contributor
|
Notes:
|
Contributor
|
Now that we can replace MD5 with xxh128, I have submitted PR #54690. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Allows to compare two files if these exists and their hashes are the same.
It will always return
falseif one of the compared files doesn't exist.Why?
Useful to check if a file copied was later edited without using
exists()andhash()damn every time.BC?
Is not expected the developer to have a macro of the same name for different functionality.