[9.x] Revert some Carbon::setTestNow()
removals
#41810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert about half of cleanup PR #40790 that removed "useless" calls to
Carbon::setTestNow()
. Now some tests are non-deterministic and can intermittently fail for new PRs being submitted:e.g., https://github.com/laravel/framework/runs/5798854285
The mocked cache expiry was unexpectedly 1 second in the future.
Carbon::setTestNow(Carbon::now())
keeps time-based mocks and assertions deterministic. Otherwise if the clock's second ticks over mid-test, assertions and mockery checks can be run on an unexpected time of day.Carbon::setTestNow(null)
at the end of the test case method. If that test fails,Carbon::setTestNow(new Carbon('2018-01-01'))
is now leaking into subsequent tests.try { /* assertions */ } finally { Carbon::setTestNow(null); }
.