[9.x] Add inbound option to CastMakeCommand - #41838
Merged
taylorotwell merged 2 commits intoApr 5, 2022
Merged
Conversation
smokills
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all! It's me, again.
I know, maybe 3 PR in a so short time is too much, but I'm working on a quite big project, and while I'm developing features, I'm also trying to find some little common patterns that maybe can be helpful to the rest of the community as well. One of those is the ability to generate inbound cast classes with the
make:castcommand. I saw that previously someone tried to add this feature, but the PR wasn't merged.I'm finding this, in my case obviously, very helpful, because I'm using a lot of Inbound Casts, and maybe someone else could benefit from this.
I also tried to write tests, but I didn't manage to find where the tests for generators commands are. So if you are going to merge this, I will be grateful if you can suggest to me where to find them.
Thanks a lot again for your time!