Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] fix SQLServer test #41984

Closed
wants to merge 1 commit into from
Closed

[9.x] fix SQLServer test #41984

wants to merge 1 commit into from

Conversation

jhavenz
Copy link
Contributor

@jhavenz jhavenz commented Apr 15, 2022

This fixes the failing SQLServer builder test submitted in #41896, referenced here:
https://github.com/laravel/framework/runs/6003485596?check_suite_focus=true

@jhavenz jhavenz marked this pull request as draft April 15, 2022 02:01
@jhavenz jhavenz mentioned this pull request Apr 15, 2022
Merged
@jhavenz jhavenz marked this pull request as ready for review April 15, 2022 02:48
@jhavenz jhavenz changed the title [9.x.] fix SQLServer test [9.x] fix SQLServer test Apr 15, 2022
@derekmd derekmd mentioned this pull request Apr 15, 2022
Merged
@driesvints
Copy link
Member

I feel like we should go ahead with #41985 as that's a better alternative. Thanks!

@jhavenz jhavenz deleted the feature/fix-sql-server-builder-test branch April 16, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhavenz @driesvints @taylorotwell @jhavens-rcn