[9.x] Support 'IS' and 'IS NOT' PostgreSQL operators #42123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuskooche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to use the IS or IS NOT operators for example in the whereRelation() function.
The problem is that the
Illuminate\Database\Query\Builderdoes not support these operators.It would work if these operators were included in this array.
https://github.com/laravel/framework/blob/9.x/src/Illuminate/Database/Query/Builder.php#L199-L206
The
whereRelation()calls internally thewhere()function inside theIlluminate\Database\Query\Builder, which changes unsupported operators to=.https://github.com/laravel/framework/blob/9.x/src/Illuminate/Database/Query/Builder.php#L739-L741
This is the reason why some queries raises an SQL exception.
For example for a query like this
SELECT * FROM table WHERE xy IS TRUEThis is because Postgres uses real boolean values and in some cases you cannot use
= 1.Mentioned in the discussion: #42101