[9.x] Support kebab case for slot name shortcut #42574
Merged
taylorotwell merged 6 commits intoMay 31, 2022
Merged
Conversation
The inline slot name shortcut was added in laravel 9 but it does not comply with the blade component kebab case naming convention (for when the slot name has more than 1 word). This edit will will make the feature fit intuitively with the blade component naming conventions.
A new capture group was added in order to support kebab case so the check for the existence of the dynamic component should be increased by 1
the pattern should have been a non capturing group instead of incrementing the index for matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revision of #42536 as per @taylorotwell's request
The inline slot name shortcut was added in laravel 9 but it does not comply with the blade component kebab case naming convention.
This PR will make the feature fit intuitively with the blade component naming conventions.
Any kebab-cased slot names will be converted to camelCase so they can be used like so:
Previously this would have to be done like this:
Not bad, but it doesnt fit conventions and a multiword slot-name example isn't provided in the documentation.
Breaking Changes?
There are no breaking changes, slot names provided in camelCase or in snake_case will continue work the same.