[8.x] Loose comparison causes the value not to be saved#42793
Merged
Conversation
MasterRO94
reviewed
Aug 15, 2022
MasterRO94
left a comment
Contributor
There was a problem hiding this comment.
This PR breaks BC. If original $value is null then PHP Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated is thrown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR back-ports #41337 to 8.x branch.
The description below is copied from the original PR.
Given an attribute with the cast object or collection, the $model->isDirty() method returns the wrong value due to the use of loose comparison.
Example from issue #37961: