[9.x] Support closures as values for about command - #43225
Merged
Conversation
about command
SamuelMwangiW
marked this pull request as ready for review
July 17, 2022 01:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The PR proposes to support closures as values for the
aboutcommand e.gWhy
I can see how handy to delay computation of some metrics and not have to evaluate the same with every request.
Also since its intended that Packages would be able to add sections to
aboutcommand outputTests
I couldn't find tests from the inital PR to add to but can add if requested.
Thanks for the great work