[9.x] Adds enum casting to Request#43239
Merged
Merged
Conversation
Contributor
|
I just added a PR to improve type definitions of this. By the way, I was thinking, shouldn't there be a way to get non-nullable Enum? For example, if I validate the input as an enum, I know it is a valid Enum value later. $request->validate(['type' => ['required', new Enum(MyEnum::class)]);
$type = $request->enum('type', MyEnum::class);
// currently this is MyEnum | nullCurrently, I had two ideas.
Then, call it as
As this is already deployed to public 9.0, we will need to reserve the Any ideas? @emargareten |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(same as #43169 for 9.x)
This PR allows to conveniently retrieve an input from the Request as an enum.