[9.x] Prevent error in db/model commands when using unsupported columns - #43635
Merged
Conversation
|
@jbrooksuk @joedixon |
joedixon
force-pushed
the
fix/db-commands
branch
from
August 10, 2022 08:59
5e68c38 to
f8862ba
Compare
jbrooksuk
approved these changes
Aug 10, 2022
joedixon
marked this pull request as ready for review
August 10, 2022 09:09
Sergiobop
reviewed
Aug 10, 2022
nunomaduro
requested changes
Aug 10, 2022
Contributor
|
Thanks for addressing this @joedixon ! I opened a PR at #43645 for the same issue, so I guess my PR can be closed. There are two things to consider concerning your implementation:
|
Contributor
Author
|
Hey @lupinitylabs - thanks for bringing the additional missing mapping to my attention. I've gone ahead and added some more that we were missing support for. I'm not sure it's worth conditionally checking the database type as if it's only an issue with, for instance, MySQL, the other database types won't be impacted anyway. |
Contributor
|
Yes, I guess since we are just reading the structure anyways, just mapping it all to string might be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR resolves #43630 #43622
The
doctrine/dbalpackage does not support enum types when listing database columns. This PR adds support for mappingenumandsysname(issue with some distributions of sqlsrv) tostring. The Artisandb:show,db:tableandmodel:showcommands have all been updated to use it.Additonally,
db:showuses therescuehelper to prevent an error if the engine type is not available. This PR also prevents the error from being reported.