[9.x] Allow for int value parameters to whereMonth() and whereDay()#43668
Merged
taylorotwell merged 1 commit intoAug 15, 2022
Merged
Conversation
Contributor
Author
|
Looks like the failing test is unrelated...? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to pass an integer value to whereMonth() or whereDay(), e.g.
PHPstan will report
Parameter #3 $value of method Illuminate\Database\Eloquent\Builder<App\Models\User>::whereMonth() expects DateTimeInterface|string|null, int given.At the same time,
will accept integer values.
This PR suggests to make the type definitions for
whereYear(),whereMonth()andwhereDay()more consistent by adding the int type to the @param docblock for$value.I am swapping out the usage of
str_pad()withsprintf()because the latter will accept mixed arguments, whereas forstr_pad(), we would have to convert int values to strings first (and it's more compact, too).