[9.x] db:table command properly handle table who doesn't exist - #43669
Merged
Conversation
db:table command properly handle table who doesn't exist.db:table command properly handle table who doesn't exist.
jbrooksuk
requested changes
Aug 12, 2022
Co-authored-by: James Brooks <jamesb@hey.com>
db:table command properly handle table who doesn't exist.db:table command properly handle table who doesn't exist
jbrooksuk
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
db:tabledoesn't proper handle table who doesn't exist.When I first tried it, I run
artisan db:table user(forgot the s) and instead of getting an error message I got an error:This PR fix it by checking if table exists before accessing any properties.