Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Formatting #44059

Merged
merged 1 commit into from
Sep 9, 2022
Merged

[9.x] Formatting #44059

merged 1 commit into from
Sep 9, 2022

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Sep 9, 2022

PHP-CS-Fixer released a new rule no_trailing_comma_in_singleline which replaced some deprecated rules and enforces the new style by default.
Pint already has received the update laravel/pint#109 but it seems like StyleCI has not been updated to reflect the new rule (with the option array_destructering which is enabled by default by PHP-CS-Fixer)

I maintain the Repo https://github.com/Jubeki/laravel-code-style which executes daily tests and formatting based on the framework. Since StyleCI doesn't enforce the rule yet, the tests fail and I would like to fix that.

@Jubeki Jubeki changed the title formatting Formatting Sep 9, 2022
@Jubeki Jubeki changed the title Formatting [9.x] Formatting Sep 9, 2022
@driesvints driesvints merged commit 1b20ec4 into laravel:9.x Sep 9, 2022
@driesvints
Copy link
Member

Thanks!

@Jubeki Jubeki deleted the formatting-new-phpcsfixer-rule branch September 9, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants