Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Fix BC issues introduced in #44080 #44137

Merged
merged 3 commits into from Sep 15, 2022
Merged

[9.x] Fix BC issues introduced in #44080 #44137

merged 3 commits into from Sep 15, 2022

Conversation

gocanto
Copy link
Contributor

@gocanto gocanto commented Sep 15, 2022

Hi team, following this PR: #44080

We introduced a BC issue where the app will fail if that argument is not there. Thus, we need to keep it as it was when arguments are not present.

Issue

0 passed in /Users/FOO/bar-api/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php 
on line 582 and exactly 1 expected

@gocanto gocanto changed the title Fix BC issues [9.x] Fix BC issues Sep 15, 2022
@gocanto gocanto changed the title [9.x] Fix BC issues [9.x] Fix BC issues introduced in #44080 Sep 15, 2022
@taylorotwell taylorotwell merged commit 71fbb30 into laravel:9.x Sep 15, 2022
@gocanto gocanto deleted the hotfix/check-for-arguments branch September 16, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gocanto @taylorotwell