[9.x] Improves dd clickable link on multiple editors and docker environments - #44406
Merged
Merged
Conversation
This was referenced Sep 30, 2022
…amework into feat/better-dd-editor-support
|
For me with the following configuration it indeed worked on WSL2 👌 |
base_path and custom href on dd source outputdd clickable link on multiple editors and docker environments
nunomaduro
marked this pull request as ready for review
October 3, 2022 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses both #44378, and #44360, and it provides 4 new things:
sublime,textmate,emacs,macvim,phpstorm,idea,vscode,vscode-insiders,vscode-remote,vscode-insiders-remote,vscodium,atom,nova,netbeans,xdebug. Note, operating system still need to support these protocols in order this to work.docker, they may now define the project'sbase_path. Not that now, people need to use thearrayformat, and not a simplestring:hrefformat — instead of specifying the editor'sname:ddoutput on console equally use thehrefapproach we are using on the HTTP layer.